-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major changes in memory usage #301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stops storing all read files in memory. This change applies to regular files only, not pipes or compressed files. Change to control by channel to make it work more asynchronously. Change File Watch to Directory Watch to react to file descriptor changes.
This partially resolves issue #201. |
Recreated Exec and deprecated ExecCommand. Separate the control part. ControlNonFile integrated into ControlFile.
Follow the file name even if the file descriptor changes.
log needed a separate controller.
Cleaned up the debug output and cleaned up the code. Added openFileReader to avoid duplication
Includes fix for #155 |
I added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops storing all read files in memory.
This change applies to regular files only,
not pipes or compressed files.
Change to control by channel to make
it work more asynchronously.
Change File Watch to Directory Watch
to react to file descriptor changes.